Jump to content

mrmath

Active Members
  • Posts

    6
  • Joined

  • Last visited

Posts posted by mrmath

  1. The program won't seem to download any songs with mrmath's version that I finally got to work after figuring out that it no longer worked in Firefox but only IE (what's up with that?!).

    Actually, it's supposed to be the other way around. It should work in firefox, but not in IE. My wife is using my version in firefox, and after I fixed the issue with the procedure names, it works fine. I'm working on merging my version with CF's version, and we hope to have a new version out soon. You can get the latest, of course, at http://sourceforge.net/projects/pandoras-jar.

    MrMath/Rick

  2. it's pandora, they've made it so it's not compatible with pandora's jar anymore.

    Those sneaky guys over at Pandora.

    Here's the fix:

    0) Make a backup copy of pandoraGrabber.js in the pandorajs folder.

    1) Open pandoraGrabber.js in your favorite editor. Note that Windows users may need to use WordPad instead of Notepad

    2) Replace every instance of "downloadMP3" with "pandorasJarDownloadMP3"

    3) Replace every instance of "downloadMP3Response" with "pandorasJarDownloadMP3Response"

    4) Save the new file

    Start pandora over again.

    A better idea would be to replace the name of the function with something random. This way they can't do it again. For example, replace "downloadMP3" with "IloveToDownalodMP3s" or replace "downloadMP3Response" with "fxzqrste".

  3. second' date=' bugs... adding features is great but what about solving bugs? does your version still have the "&" bug that's in 7.4.0?[/quote']

    I knew I forgot to mention something. Yes, I did fix that. Thanks for reminding me.

    now for the rest of the comments...

    I think we should work together instead of in parallel' date=' my version is available on sourceforge, you are more than welcome to join the project and contribute. there are even a few open bugs[/quote']

    That requires an actual commitment, and doing work that's assigned to me, right? I'm just doing things that come to mind, and I got to the point were I felt it was worth sharing... I guess I'm too lazy for a real project such as yours. Who knows. Maybe I'll change my mind.

    here are my comments about your version' date=' this is just my opinion and thoughts - nothing more:[/quote']ALWAYS WELCOME! Thanks!

    - Changed the save format form Artist-Song.mp3 to Artist - Song.mp3. This is just my personal preference.

    My version supports arbitrary file name format with custom string %a/%a-%t and so on' date=' I think that's much better.[/quote']

    You're right on that count. Much better plan!

    - Added pandora.db file.

    by preventing files from being re-ripped you indeed avoid ripping files that you have deleted - but what if a file was ripped but under the wrong name? you're stuck with it.

    In addition - take a look at my mp3md5 (both local and online modes) feature - this is my way of fixing (though not completely) the wrongfully named tracks problems

    pandora.db is a plain text file. You can remove a song from there and it will re-rip if it comes up again.

    - Added exclude.db file.

    great feature

    - Fixed the album art

    great!

    Thanks!

    - Added a preference to save the file in a directory with the artist's name.

    - Added a preference to save the file in a directory with the station's name. Won't have any affect if you set it to NOT save it in the artist's name directory.

    again' date=' it is much better to enable the user to enter a generic string for the file path.[/quote']

    This does make my prefs kind of useless.

    p.s.

    If you'd like me to store your version on my server for everyone to download - let me know.

    You don't have to, but if you can, that would be great!

    I did comment all my code with "Modified by Rick Seiden", so you can feel free to go through the code and pick my code out. Maybe I'll change my mind about joining the CF team. Who knows.

  4. I just finished work on a modification of Pandora's Jar. I know this creates splits and what not, but I had some stuff I wanted, and I put it in. I then figured I would share it. The standard stuff applies here. It's GPL. The codes included. So on.

    OOPS! I forgot to mention that you need to install the pandorajar.user.js Greasemonkey script in order for the background to look right on the default skin.

  5. I just finished work on a modification of Pandora's Jar. I know this creates splits and what not, but I had some stuff I wanted, and I put it in. I then figured I would share it. The standard stuff applies here. It's GPL. The codes included. So on.

    You can download my version at http://www.filefactory.com/file/612a72/. Search for "Download for free with FileFactory Basic" and click it. Forgive me for the popups and ads.

    What makes my version worth it?

    - Changed the save format form Artist-Song.mp3 to Artist - Song.mp3. This is just my personal preference.

    - Added pandora.db file. This file will store the filenames of all ripped files. When a song is going to be ripped, this file is checked. If it's found in there, it does not save it again. If it's not found, the song is ripped, and the pandora.db file is updated. I did this because I noticed that if I deleted a file, it might get re-ripped. This will stop that from happening. That's the good news. The bad news is that if a song gets ripped, but the album info wasn't found, and then it comes around again, it won't even bother to look for the album info. I've had it happen where the album info gets found on the second run.

    - Added exclude.db file. This file, which must be updated manually, contains a list of artists you don't want to rip. Each artist get's its own line.

    - Fixed the album art so it gets downloaded and saved with the mp3. It is saved in a temp directory, so it doesn't "clog" up your hard drive. This also fixes an issue when we can't get the album name from the CDDB. How do I get the album art without the album name? Pandora provides us with a URL to the album art. Gracenote provides us with the CDDB info. Sometimes Gracenote doesn't return the album, but we still have the art from Pandora.

    - Added a preference to save the file in a directory with the artist's name.

    - Added a preference to save the file in a directory with the station's name. Won't have any affect if you set it to NOT save it in the artist's name directory.

    - Added a preference to use as a default genre.

    - Made it use the Pandora Radio station name as the genre. It takes the part of the name before the " Radio" and makes that the genre. If, for example, you had a radio station called "Country Radio", the genre would be "Country". If this doesn't work, or you're listening to the QuickMix station, then it uses the default genre.

    - This one won't be popular, I'm sure, but I needed to do it for me. Pandora is supported by ads. The ads pay the royalties. By not showing the ads, I think we're cheating them out of money they would get. I know that the ads are downloaded to my computer, but not shown because of the way the Pandora player is displayed, but I still feel bad. You use an ad supported site, you should display the ads. If you don't like this, you can change the skin from the default skin. That's the only one I did it to. Note that this does not slow anything down. The ads were being downloaded, but not shown. All I did was let them show.

    - Probably some bugs, but I tried not to.

    Comments, questions, whatever: pandorasjar@seidenmail.com

  6. // grab local version of browser object because jquery will wipe out $
    
    browser = $.browser;
    
    checkBrowser = true;
    
    
    
    (function() {
    
        var div;
    
        var version = deconcept.SWFObjectUtil.getPlayerVersion().major;
    
    
    
        if (window.top != window && browser.firefox() && version < 9) {
    
            div = "needsFlash9Upgrade";
    
        } else if (checkBrowser && browser.win() && browser.msie() && browser.version.number() < 5.5) {
    
            div = "needsIEUpgrade";
    
        } else if (version == 0 && window.ActiveXObject && !hasActiveX()) {
    
            div = "needsActiveX";
    
        } else if (version == 0) {
    
            div = "needsFlashInstall";
    
        } else if (version < MINIMUM_FLASH_VERSION) {
    
            div = "needsFlashUpgrade";
    
        } else if (location.search && location.search.match(/error=(w+)/)) {
    
            div = RegExp.$1;
    
        } else {
    
            div = null;
    
        }
    
    
    
        if (div == null) {
    
            // flash is installed.  embed away.

    So if you're using Firefox and Flash < v9 it'll display the div rather than embedding the flash.

    Someone with better javascript skills than me should be able to override that methinks. Perhaps a little greasemonkey action?

    Where did you find this code? I'd like to try and play with it, but can't find it.

    Thanks

    Rick

×
×
  • Create New...