zerko Posted June 8, 2006 Share Posted June 8, 2006 Cooper, It doesn't work for me (with the MrDave2176's html)... Sorry. Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 It was entirely untested, so no really big surprises there. Any errors you're getting? With this modification in place the assumption is made that the files are placed in your %TEMP% folder. Could you verify that that's what's actually happening? Quote Link to comment Share on other sites More sharing options...
dubby Posted June 8, 2006 Share Posted June 8, 2006 The $1 and $2 class files should be generated along with Mp3Processor.class in the same compiler output location. They are just anonymous inner classes in the Mp3Processor.java source (one is a Comparator for sorting file names and the other is the one I added which is a FilenameFilter... as if you care...). Looks like someone made the mods, rebuilt the jar, and posted it anyway. That should be easier unless you just really want to do it all yourself. Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 It was entirely untested, so no really big surprises there.Any errors you're getting? With this modification in place the assumption is made that the files are placed in your %TEMP% folder. Could you verify that that's what's actually happening? There are plugtmp files in my %TEMP% directory, but no normal grabbing with renaming etc. (It seems that there is no error). With the new skin, I have absolutely no message in the status field. Is it normal ? Quote Link to comment Share on other sites More sharing options...
crus Posted June 8, 2006 Share Posted June 8, 2006 for me it works with the jar file...(using beta5) Quote Link to comment Share on other sites More sharing options...
dubby Posted June 8, 2006 Share Posted June 8, 2006 Absolutely untested... except for the one test I did... which might have been a fluke... but it worked. Don't you just love hacks on beta code that is attempting to 2nd guess an uncooperative 3rd party system in the 1st place. I did notice that in some cases, Pandora is pre-loading the "next" song before it is even displayed or played. That might be sending pandora.jar for a trip. I didn't look over that part of the code too closely. I just tried to get the file name identification working and left the rest of it alone. Quote Link to comment Share on other sites More sharing options...
dahoff Posted June 8, 2006 Share Posted June 8, 2006 Thanks for all the great work that you've done on this Cooper! The new jar you released has been working for me so far with no problems. Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 It had worked without one time for me with this config : 1) The beta-5 2) The new jar files by Cooper 3) The new skin by MrDave2176 But after it has stopped working... There is absolutely no message in status fields and in the jar. Quote Link to comment Share on other sites More sharing options...
thelasersailor Posted June 8, 2006 Share Posted June 8, 2006 Has not worked for me. Says initiating MP3 rip the Unable to rip MP3 null Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 @thelasersailor: Could you please download this one and use it to overwrite your current pandora.jar: http://comicnut.speedxs.nl/pandora_logging.jar The only difference is in the logging. This version should include a stacktrace of the exception that's being thrown, hopefully shedding some light on what's going wrong. Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 @thelasersailor:Could you please download this one and use it to overwrite your current pandora.jar: http://comicnut.speedxs.nl/pandora_logging.jar The only difference is in the logging. This version should include a stacktrace of the exception that's being thrown, hopefully shedding some light on what's going wrong. I've done it. Here is the log : INFO main client.Client - initing app INFO Thread-2 server.Server - running INFO Thread-2 server.Server - Welcome to Pandoras Jar INFO Thread-2 server.Server - Attempting to lauch on port 8085... INFO Thread-2 server.Server - OK! INFO Thread-2 server.Server - [ready, lets grab some MP3's!!!] INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET / HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET / HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = INFO Thread-2 servlet.ProcessAction - documentType = HTML INFO Thread-2 servlet.ProcessAction - fileType = HTML INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /js/pandora.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /js/pandora.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = js/pandora.js INFO Thread-2 servlet.ProcessAction - documentType = JS INFO Thread-2 servlet.ProcessAction - fileType = JS INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /js/prototype-1.4.0.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /js/prototype-1.4.0.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = js/prototype-1.4.0.js INFO Thread-2 servlet.ProcessAction - documentType = JS INFO Thread-2 servlet.ProcessAction - fileType = JS And after that it stops !! Nothing is written in the status fields of the HTML. Strange, isn't it ? Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 Your problem is different and unrelated, so the request to thelasersailor still stands. The problem which you appear to have is that the javascript functions on your html page don't appear to be (able to) call the server to grab the MP3. Is there anything in the Javascript console of your browser (assuming you've got one of those. Mozilla usually does...)? Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 Maybe too quick to label it as unrelated. When you click the 'grab it' link you'll probably get that same error, aren't you? Ran it locally now so I've got some pointers. Lemme take a look and investigate. Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 Ok. I've deactivated the cruise control. When I clic on "grab it", it gives me that : INFO main client.Client - initing app INFO Thread-2 server.Server - running INFO Thread-2 server.Server - Welcome to Pandoras Jar INFO Thread-2 server.Server - Attempting to lauch on port 8085... INFO Thread-2 server.Server - OK! INFO Thread-2 server.Server - [ready, lets grab some MP3's!!!] INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET / HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET / HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = INFO Thread-2 servlet.ProcessAction - documentType = HTML INFO Thread-2 servlet.ProcessAction - fileType = HTML INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /js/pandora.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /js/pandora.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = js/pandora.js INFO Thread-2 servlet.ProcessAction - documentType = JS INFO Thread-2 servlet.ProcessAction - fileType = JS INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /js/prototype-1.4.0.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /js/prototype-1.4.0.js HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = js/prototype-1.4.0.js INFO Thread-2 servlet.ProcessAction - documentType = JS INFO Thread-2 servlet.ProcessAction - fileType = JS INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /images/warheadtwo1rk.gif HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /images/warheadtwo1rk.gif HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = images/warheadtwo1rk.gif INFO Thread-2 servlet.ProcessAction - documentType = GIF INFO Thread-2 servlet.ProcessAction - fileType = GIF INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /images/tile1.jpg HTTP/1.1 INFO Thread-2 servlet.ProcessAction - processing static request. path: GET /images/tile1.jpg HTTP/1.1 INFO Thread-2 servlet.ProcessAction - path = images/tile1.jpg INFO Thread-2 servlet.ProcessAction - documentType = JPG INFO Thread-2 servlet.ProcessAction - fileType = JPG INFO Thread-2 server.Server - localhost connected to server. INFO Thread-2 server.Server - handling request INFO Thread-2 server.Server - processing url: GET /process?action=grab&artist=&title=&album=&genre=&comment=ripped%20by%20[PaNDoRas%20jAR]%20your%20source%20for%20listening%20pleasure&year=&cruise=off&albumImgLocaction=&pandoraUserName=&stationId=30584064&cddbLookUp=on&_= HTTP/1.1 INFO Thread-2 servlet.ProcessAction - handling mp3 request INFO Thread-2 util.Mp3Processor - locating mp3 INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec INFO Thread-2 util.Mp3Processor - access file not found trying again after 1 sec (and the same to infinite) I hope I will help you (my Java component seems totally normal). Thanks ! Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 If you see this: java.lang.NullPointerException at java.io.File.<init>(File.java:194) at util.Mp3Processor.findUserTmpDir(Mp3Processor.java:134) It means the TEMP environment variable wasn't around when the server was started. So, fixed that (that's what you get when you run it under Linux unprepared. Yes, I did say Linux), now when I click 'grab it' it says this: INFO [Thread-1] (Server.java:102) - processing url: GET [long url that messes up the formatting] HTTP/1.1 INFO [Thread-1] (ProcessAction.java:24) - handling mp3 request INFO [Thread-1] (Mp3Processor.java:24) - locating mp3 INFO [Thread-1] (Mp3Processor.java:57) - plugtmp-1-1|plugtmp-1-1 INFO [Thread-1] (Mp3Processor.java:165) - copying file[/tmp/plugtmp-1-1] to temp[/tmp/temp] WARN [Thread-1] (ProcessAction.java:65) - unable to save img - albumImgLoc: null songInfo: SongInfo{album='null', artist='null', title='null', trackNumber='null', year='null', lable='null', genre='null'} INFO [Thread-1] (Mp3Processor.java:179) - adding ID3 tags: SongInfo{album='null', artist='null', title='null', trackNumber='null', year='null', lable='null', genre='null'} INFO [Thread-1] (Server.java:112) - unable to rip MP3 java.lang.NullPointerException at util.SafeString.getSafeFileName(SafeString.java:5) at util.Util.createSongHierarchy(Util.java:123) at util.Mp3Processor.saveMP3(Mp3Processor.java:232) at servlet.ProcessAction.handleMP3Request(ProcessAction.java:72) at server.Server.handleHTTPRequest(Server.java:110) at server.Server.run(Server.java:83) INFO [Thread-1] (Server.java:42) - unable to rip MP3 null So for some reason none of the info that Pandora knows about the track is being passed on to the server. Does this in any way resemble what you're seeing? Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 I doesn't resemble my situation. I forgot to say that in the status field there was this : HTTP/1.0 500 Internal server.Server Error Date: Thu Jun 08 12:30:21 CEST 2006 Content-Type: text/html Cache-Control: no-cache, no-store, must-revalidate, max-age=-1 server.Server: Pandoras Jar Connection: close unable to rip MP3 null Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 I get that aswell when the above happens. I'm starting to feel we should maybe start looking at Musicbrainz to tag the file, and then use the data found there to do the rest... Or are we three the only ones with issues? Quote Link to comment Share on other sites More sharing options...
gwyden Posted June 8, 2006 Share Posted June 8, 2006 I am having the same issue. Should i try that new jar you posted earlier? or should i got with the one with a lot of debugging? Quote Link to comment Share on other sites More sharing options...
desyressylence Posted June 8, 2006 Share Posted June 8, 2006 I'm actually getting something completely different with the new jar. INFO [Thread-2] (Server.java:85) - handling request INFO [Thread-2] (Server.java:86) - processing url: GET /favicon.ico HTTP/1.1 INFO [Thread-2] (ProcessAction.java:95) - processing static request. path: GET /favicon.ico HTTP/1.1 INFO [Thread-2] (ProcessAction.java:97) - path = favicon.ico INFO [Thread-2] (ProcessAction.java:111) - documentType = ICO INFO [Thread-2] (Server.java:34) - No enum const class enums.FileType.ICO java.lang.IllegalArgumentException: No enum const class enums.FileType.ICO at java.lang.Enum.valueOf(Unknown Source) Â Â Â Â Â Â Â Â at enums.FileType.valueOf(FileType.java:7) Â Â Â Â Â Â Â Â at servlet.ProcessAction.handleStaticRequest(ProcessAction.java:112) Â Â Â Â Â Â Â Â at server.Server.handleHTTPRequest(Server.java:131) Â Â Â Â Â Â Â Â at server.Server.run(Server.java:67) INFO [Thread-2] (Server.java:34) - localhost connected to server. INFO [Thread-2] (Server.java:85) - handling request INFO [Thread-2] (Server.java:86) - processing url: GET /process?action=grab&artist=Sparkle&title=Time%20To%20Move%20On&album=&genre=&comment=ripped%20by%20[PaN DoRas%20jAR]%20your%20source%20for%20listening%20pleasure&year=&cruise=on&albumI mgLocaction=&pandoraUserName=&stationId=27388943&cddbLookUp=off&_= HTTP/1.1 INFO [Thread-2] (ProcessAction.java:24) - handling mp3 request INFO [Thread-2] (Mp3Processor.java:24) - locating mp3 INFO [Thread-2] (Server.java:34) - unable to rip MP3 String index out of range: -1 java.lang.RuntimeException: unable to rip MP3 String index out of range: -1 Â Â Â Â Â Â Â Â at server.Server.handleHTTPRequest(Server.java:96) Â Â Â Â Â Â Â Â at server.Server.run(Server.java:67) Oddly enough on my second computer (same configuration / same files) it works fine. *shrug* Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 Could you try the pandora_logging.jar file please? Just overwrite your pandora.jar file with it and restart the program. Quote Link to comment Share on other sites More sharing options...
thelasersailor Posted June 8, 2006 Share Posted June 8, 2006 Tried current pandora.jar on a different computer and worked fine may be just something wrong with my computer (not up to date java?) Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 (not my desktop. Hope the guy that sent me this doesn't mind) That is what running the program under java 1.4 looks like. Quote Link to comment Share on other sites More sharing options...
thelasersailor Posted June 8, 2006 Share Posted June 8, 2006 looks like that Quote Link to comment Share on other sites More sharing options...
cooper Posted June 8, 2006 Share Posted June 8, 2006 Then yes, you need to upgrade to Java 1.5. http://javashoplm.sun.com/ECom/docs/Welcom...sactionId=noreg Quote Link to comment Share on other sites More sharing options...
zerko Posted June 8, 2006 Share Posted June 8, 2006 I approximatively looks like that on my computer, but I have Sun Java 1.5. Cooper, I admire your courage and determination. Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.