Jump to content
Sign in to follow this  
kuyaya

Pull request review

Recommended Posts

How long does it usually take the hak5 team to review/accept/decline your pull request?

Share this post


Link to post
Share on other sites

Too long, and that's my fault. I really need to find a scalable solution to this but thus far haven't. 

  • Like 1

Share this post


Link to post
Share on other sites
6 hours ago, Darren Kitchen said:

Too long, and that's my fault. I really need to find a scalable solution to this but thus far haven't. 

Wow, I just saw that lazassword got accepted. Just wow. I still can't belive it. My payload is on the official Hak5 github repository. That's a huge achievement for me. Thank you so much ❤️

Due to covid-19, the grammar school I'm at also closed, and now I have ~1 week leisure time (1 week till distance learning starts). I have plenty of time to review all of the pull requests. I don't have writing permissions but I can still review them😉. When I say "add a readme to your repository" you already know that the readme is missing. You should be much faster to go through them. That should take a bit of work from your shoulders.

I mylself have to update the readme on lazassword. Forgot something. Shame on me....

Share this post


Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

Loading...
Sign in to follow this  

  • Recently Browsing   0 members

    No registered users viewing this page.

×
×
  • Create New...