leathalinjexion Posted December 20, 2014 Posted December 20, 2014 I would like to contribute by helping with the web interface javascript, I work with JavaScript at an enterprise level and would like to help setup name spaces for the api and infusions, im happy to send PR's for review but wanted to touch base so i don't undo or step on any toes. Stuff like the following // set up namespace for sharing across multiple files var MyApp = MyApp || {}; (function(window, $, exports, undefined) { 'use strict'; // if this function or object should be global, attach it to the namespace exports.myGlobalFunction = function(params) { return params; }; })(window, jQuery, MyApp); Quote
Oli Posted December 20, 2014 Posted December 20, 2014 I wouldn't bother just yet as the github is never updated... For code contributions to work properly, a meaningful infrastructure needs to be in place. https://github.com/WiFiPineapple/MK5_Interface Excluding the infusions, the code might as well be closed source. Quote
leathalinjexion Posted December 20, 2014 Author Posted December 20, 2014 that's easy enough to deal with, assuming the latest version is on the pineapple after flashing the latest firmware, ill just work off that, I can send PR's to merge and keep it all updated easy peezy Quote
DataHead Posted December 20, 2014 Posted December 20, 2014 Sounds great! I guess one could just commit the 2.1.1 web interface from the internal storage to the github :-) Quote
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.