Jump to content

fie

Active Members
 View Profile  See their activity

  • Posts

    5

  • Joined

  • Last visited

  • Days Won

    1

 Content Type 

Posts posted by fie

    Pianobarfly

    in Pandora Timeshifting

    Posted

    ah nice looks good - i was looking at the original source that you posted.

    Ok, NEW VERSION!

    Fixed the recalling fopen()

    Fixed the volume controls (, down | . up)

    Added track position skip ahead. (/)

    Right now the skip ahead jumps 128 mp3 frames. I'll work on reversing the track position but that's going to be a lot of work/time.

    Pianobarfly

    in Pandora Timeshifting

    Posted

    It looks like it'd be overwriting existing files - in BarPlayerBufferFill.

    FILE *fp = fopen(player->tmpname, "ab");

    fwrite(data, dataSize, 1, fp);

    fclose(fp);

    Actually, that'd just be sticking more data on the end of the existing file...

    Got ya! We're looking at different code again :D.

    If you re-download, it should be in there.

    The volume controls on the version online are screwed up but I've fixed that. I also made it so that it doesn't call fopen for each write. Worked on that the first part of the day. I'm trying to see if I can get time shifting working before I upload all of the changes but that will be a few hours from now. I don't think I'm going to be able to get it going today though.

    Pianobarfly

    in Pandora Timeshifting

    Posted · Edited by fie

    I added volume controls this morning.

    , for volume down and . for volume up

    I changed the buffer size on names/directories.

    said stuff

    Why do you say that it doesn't respect exists?

    --edit

    Maybe the condition believes in existential nihilism?

    Pianobarfly

    in Pandora Timeshifting

    Posted

    Surprised it took so long for someone to finally bite the bullet and do it.

    Some suggestions, looking at the source:

    - You might want to mangle the stream selection logic so it only requests mp3-hifi - this will cause any client to get 128kbs mp3, and 192kbs if they are subscribers.

    - Tagging logic would be nice - take a look at id3ed

    - You'll probably want to remove various "bad" path chars, though windows is a bit more restrictive than linux when it comes to that so it might not be needed.

    - Artist/album/title fields are too small - i'd recommend putting them in the region of 250 or so, just to be safe. Pandora likes long names, especially when it comes to classical music.

    - You might want to disable skip (or handle when it does occur) as it'd leave a truncated stream

    Oh, and about that one comment; I'm only here for this forum, never watched the show. Guess i shouldn't bother.

    And I was so positive that nobody would ever find that. I thank you for proving me wrong. It's so common now-a-days that people run code without checking it first.

    I do remove bad path characters.

    I was pretty sure that pianobar automatically selected 192 if you have it.

    At the moment I'm working on having a better understanding of how input is handled with it. I want to add the very basic feature of volume control. It ought to be quite easy (is the same thing I said when I wanted pianobar to save streams).

    But yeah, i will eventually handle skipping, id3 is up there on my list as well (already looked into it), and I will adjust the buffer size for file names etc. next time that I work on it.

×
×
  • Create New...